Add returnTo argument to signOut method #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a "returnTo" parameter to the signOut process, allowing a return URL to be specified during logout.
- Adds a returnTo parameter to terminateSession in src/session.ts and propagates it to getLogoutUrl and redirect calls.
- Updates signOut in src/auth.ts to accept the returnTo parameter and passes it to terminateSession.
- Extends tests in src/session.spec.ts and src/auth.spec.ts to cover behavior with and without a provided returnTo argument.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/session.ts | Updated terminateSession to take an optional returnTo argument and use it when constructing the logout URL. |
| src/session.spec.ts | Added tests covering both session and non-session scenarios when using the new returnTo parameter. |
| src/auth.ts | Modified signOut to accept a returnTo parameter and pass it onto terminateSession. |
| src/auth.spec.ts | Included tests to ensure signOut behaves as expected with and without a provided returnTo URL. |
nholden
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a "return to" URL to be defined and will be passed to the
getLogoutUrlmethod.capture_20250418_160334.mp4